fix: sanitise pid parameter#31
Merged
billiegoose merged 1 commit intopkrumins:masterfrom Dec 11, 2019
robcresswell:fix/command-injection
Merged
fix: sanitise pid parameter#31billiegoose merged 1 commit intopkrumins:masterfrom robcresswell:fix/command-injection
billiegoose merged 1 commit intopkrumins:masterfrom
robcresswell:fix/command-injection
Conversation
This patch adds a simple check to the process ID passed in, ensuring it is a number, and throwing an error otherwise. The aim is to fix the issue explained here: - https://hackerone.com/reports/701183 - https://snyk.io/vuln/SNYK-JS-TREEKILL-536781 Fixes: #30
This was referenced Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a simple check to the process ID passed in, ensuring it is a number, and throwing an error otherwise. The aim is to fix the issue explained here:
Fixes: #30