Update GA quote/ref in concepts-guidelines.md#1169
Merged
peter-evans merged 2 commits intopeter-evans:mainfrom Apr 13, 2022
Merged
Update GA quote/ref in concepts-guidelines.md#1169peter-evans merged 2 commits intopeter-evans:mainfrom
peter-evans merged 2 commits intopeter-evans:mainfrom
Conversation
The current quote and reference link appear to be out of date
peter-evans
requested changes
Apr 12, 2022
Owner
peter-evans
left a comment
There was a problem hiding this comment.
Thank you for spotting this!
I just have one suggestion to change the link, but otherwise looks good to me. 👍
|
|
||
| [GitHub Actions: Events that trigger workflows](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token) | ||
|
|
||
| [GitHub Actions: Automatic token authentication](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow) |
Owner
There was a problem hiding this comment.
I think this might be a slightly more relevant link. It's the same paragraph, but just a different page that is more focused around triggering workflows from runs.
Suggested change
| [GitHub Actions: Automatic token authentication](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow) | |
| [GitHub Actions: Automatic token authentication](https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow) |
Contributor
Author
|
I see, the two links (the one I used and the one you suggested) have similar text. I updated it to reference the link you suggested and also quote the exact text from that link (which itself contains a link that redirects to the link I had found). Does that look right? |
peter-evans
approved these changes
Apr 13, 2022
Owner
|
Thanks! |
aleksandrychev
pushed a commit
to aleksandrychev/create-pull-request
that referenced
this pull request
Mar 4, 2024
* Update GA quote/ref in concepts-guidelines.md The current quote and reference link appear to be out of date * Change "Triggering further workflow runs" excerpt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stumbled upon this when reading the documentation. The current quote and reference link appear to be out of date.