Skip to content

Add support for MERGE_READY_STATE option#208

Merged
pascalgn merged 7 commits intopascalgn:mainfrom
BigGillyStyle:ready_state_option
Feb 18, 2023
Merged

Add support for MERGE_READY_STATE option#208
pascalgn merged 7 commits intopascalgn:mainfrom
BigGillyStyle:ready_state_option

Conversation

@BigGillyStyle
Copy link
Copy Markdown
Contributor

This is based on the discussion in #203 and in particular this comment

@SaraRavasio
Copy link
Copy Markdown

nice one! but what if the MERGE_READY_STATE always has those values plus the one that can be passed? so it's not the default ones or the other but all of them.
would that make sense?
cc @pascalgn

@BigGillyStyle
Copy link
Copy Markdown
Contributor Author

what if the MERGE_READY_STATE always has those values plus the one that can be passed?

That's a bit of an API preference that I'll defer to @pascalgn Would it be better to have the items provided by MERGE_READY_STATE to be merged with the default or replace the default state entirely (as was done originally in this PR)? The downside of what you are suggesting is that you couldn't override the defaults. However, the upside is that you don't have to re-state (or necessarily even know about) the default values. I could see either case.

@pascalgn pascalgn merged commit 5407b38 into pascalgn:main Feb 18, 2023
@pascalgn
Copy link
Copy Markdown
Owner

Thanks for the PR, it's merged now! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants