You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
nice one! but what if the MERGE_READY_STATE always has those values plus the one that can be passed? so it's not the default ones or the other but all of them.
would that make sense?
cc @pascalgn
what if the MERGE_READY_STATE always has those values plus the one that can be passed?
That's a bit of an API preference that I'll defer to @pascalgn Would it be better to have the items provided by MERGE_READY_STATE to be merged with the default or replace the default state entirely (as was done originally in this PR)? The downside of what you are suggesting is that you couldn't override the defaults. However, the upside is that you don't have to re-state (or necessarily even know about) the default values. I could see either case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the discussion in #203 and in particular this comment