This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Fix interface name rule#4626
Merged
adidahiya merged 1 commit intopalantir:masterfrom Apr 4, 2019
VincentLanglet:fixInterfaceNameRule
Merged
Fix interface name rule#4626adidahiya merged 1 commit intopalantir:masterfrom VincentLanglet:fixInterfaceNameRule
adidahiya merged 1 commit intopalantir:masterfrom
VincentLanglet:fixInterfaceNameRule
Conversation
adidahiya
suggested changes
Apr 2, 2019
| "trailingComma": "all" | ||
| } | ||
| }, | ||
| "prettier": true, |
| @@ -0,0 +1,5 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
please revert, don't make unrelated changes like this in PRs
Contributor
Author
There was a problem hiding this comment.
Done in another PR
adidahiya
approved these changes
Apr 4, 2019
Contributor
adidahiya
left a comment
There was a problem hiding this comment.
thanks. also please avoid force-pushing to PRs in the future. using regular commits helps me review incremental changes easier. we squash at the end of a PR.
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
I stoped to use isLowerCase or isUpperCase to use a real regex. These functions was buggy with numbers.
Is there anything you'd like reviewers to focus on?
I add a better support for prettier too.
CHANGELOG.md entry:
[bugfix]
interface-namenow correctly handle numeric characters