This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Relax "no-null-undefined-union" rule.#4625
Merged
adidahiya merged 7 commits intopalantir:masterfrom Apr 4, 2019
nrathi:neha
Merged
Relax "no-null-undefined-union" rule.#4625adidahiya merged 7 commits intopalantir:masterfrom nrathi:neha
adidahiya merged 7 commits intopalantir:masterfrom
nrathi:neha
Conversation
added 4 commits
April 2, 2019 12:22
Contributor
|
Hi @nrathi Can you add a test for type Text = string | null
interface Props {
title?: Text
}
interface SuperProps {
title?: Text | number
}
function someFunc(bar?: Text, foo?: Text | number) {}I don't expect error from the rule, if you do, there should be at least an option to disable these cases. |
Contributor
Author
|
@VincentLanglet added, no errors! |
adidahiya
suggested changes
Apr 2, 2019
added 2 commits
April 4, 2019 15:56
adidahiya
approved these changes
Apr 4, 2019
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
CHANGELOG.md entry:
[rule-change] Relax
no-null-undefined-unionrule.