This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Add quotemark type validation to allow early return (#4310)#4344
Merged
JoshuaKGoldberg merged 5 commits intopalantir:masterfrom Jun 17, 2019
Merged
Add quotemark type validation to allow early return (#4310)#4344JoshuaKGoldberg merged 5 commits intopalantir:masterfrom
JoshuaKGoldberg merged 5 commits intopalantir:masterfrom
Conversation
Member
|
Thanks for your interest in palantir/tslint, @isabelleweber! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
JoshuaKGoldberg
suggested changes
Dec 6, 2018
Contributor
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Functionality looks great - just a style comment and a test fixup.
Contributor
|
👋 @isabelleweber just a heads up - I merged in |
JoshuaKGoldberg
approved these changes
Jun 17, 2019
This was referenced Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Add quotemark type validation to allow early return if not one of `,
'or".Before:
When linting something like
(a')...SyntaxError: Invalid regular expression: /\\)/: Unmatched ')'After:
No error
CHANGELOG.md entry:
[bugfix] additional
quotemarkvalidation