Merged
Conversation
Collaborator
Author
|
Seems no tests want to run. AppVeyor is acting weird for unknown reasons, while Travis claims that builds have been disabled due to lack of credits. |
Flarna
approved these changes
Jul 13, 2021
aa8f5bc to
99ae28a
Compare
Collaborator
Author
|
AppVeyor acting weird was due to VS2015 not being a proper compiler. Worked around it while sticking to C++03 by implementing forwarding constructors for all three supported constructors for all versions. |
d263bd8 to
8b85f9b
Compare
reconbot
added a commit
to serialport/node-serialport
that referenced
this pull request
Sep 20, 2021
- debug (minor changes) - [nan](nodejs/nan#918) - prebuild-install (bug fixes)
reconbot
added a commit
to serialport/node-serialport
that referenced
this pull request
Sep 20, 2021
- debug (minor changes) - [nan](nodejs/nan#918) - prebuild-install (bug fixes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To properly address #917 requires reimplementing
v8::ScriptOrigindue to v8/v8@546939f (unintentionally?) breaking the oldScriptOriginconstructor by makingresource_column_offsetrequired. Since the same commit markedScriptOrigin::ResourceLineOffsetandScriptOrigin::ResourceColumnOffsetas soon to be deprecated, they should be reimplemented. Finally, @bnoordhuis decided to add a requirement for passing av8::Isolate*in v8/v8@ee3f5ba, with the other constructors facing future deprecation.