Don't add results to finalResults once promise was notified#13196
Merged
normanmaurer merged 1 commit into4.1from Feb 7, 2023
Merged
Don't add results to finalResults once promise was notified#13196normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
chrisvest
approved these changes
Feb 6, 2023
Scottmitch
reviewed
Feb 6, 2023
Scottmitch
approved these changes
Feb 6, 2023
Member
Author
|
Actually there is something else wrong here. Let me work on this |
Motivation: We need to ensure we release the results if we dont end up transfering the ownership. In some cases we could have ended up to adding more results to the List without be sure that these will ever be released at all. Modifications: Only add results as long as we did not notify yet. Otherwise release these. Result: No more memory leak possible even if promise is already completed
fdb56a9 to
a7e4e17
Compare
normanmaurer
added a commit
that referenced
this pull request
Feb 7, 2023
Motivation: We need to ensure we release the results if we dont end up transfering the ownership. In some cases we could have ended up to adding more results to the List without be sure that these will ever be released at all. Modifications: Only add results as long as we did not notify yet. Otherwise release these. Result: No more memory leak possible even if promise is already completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to ensure we release the results if we dont end up transfering the ownership. In some cases we could have ended up to adding more results to the List without be sure that these will ever be released at all.
Modifications:
Only add results as long as we did not notify yet. Otherwise release these.
Result:
No more memory leak possible even if promise is already completed