fixing some naming and typo in transport-udt#13031
Merged
normanmaurer merged 1 commit intonetty:4.1from Dec 4, 2022
Merged
Conversation
hyperxpro
approved these changes
Dec 2, 2022
normanmaurer
approved these changes
Dec 4, 2022
Member
|
@zazf can you sign our icla and let me know once done : https://netty.io/s/icla ? |
Contributor
Author
|
@normanmaurer Signed |
Member
|
@zazf Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
I accidentally find some typos in the transport-udt module, and two of them actually can affect the correctness of execution.
Modification:
Only changed some variable namings.
Variables in some setters in DefaultUdtChannelConfig.java and DefaultUdtServerChannelConfig.java are named incorrectly.
Result:
Now, DefaultUdtChannelConfig won't set SystemReceiveBufferSize and SystemSendBufferSize incorrectly.