Close EmbeddedChannel and release all buffers once test completes#12962
Merged
normanmaurer merged 1 commit into4.1from Nov 3, 2022
Merged
Close EmbeddedChannel and release all buffers once test completes#12962normanmaurer merged 1 commit into4.1from
normanmaurer merged 1 commit into4.1from
Conversation
Motivation: de8a7ef added some new tests but missed to close the EmbeddedChannel and release the still buffered data once done. This results in a leak. Modifications: Call finishAndReleaseAll() once test completes Result: No more leaks
Member
Author
|
I noticed this while cherry-pick de8a7ef into main. There I already fixed it as part of the cherry-pick |
Member
|
Looks good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
de8a7ef added some new tests but missed to close the EmbeddedChannel and release the still buffered data once done. This results in a leak.
Modifications:
Call finishAndReleaseAll() once test completes
Result:
No more leaks