Avoid ignoring interrupts in SocketStartTlsTest and SocketSslEchoTest#12946
Merged
normanmaurer merged 1 commit intonetty:mainfrom Nov 2, 2022
Merged
Avoid ignoring interrupts in SocketStartTlsTest and SocketSslEchoTest#12946normanmaurer merged 1 commit intonetty:mainfrom
normanmaurer merged 1 commit intonetty:mainfrom
Conversation
Motivation: JUnit relies on interrupts to communicate test timeouts. When we silently swallow interrupts, we break this mechanism. Modification: Make the loops in SocketStartTlsTest and SocketSslEchoTest throw their interrupts instead of silently swallowing them. Result: The tests now responds to timeouts.
919a286 to
ea0538b
Compare
normanmaurer
pushed a commit
that referenced
this pull request
Nov 2, 2022
…#12946) Motivation: JUnit relies on interrupts to communicate test timeouts. When we silently swallow interrupts, we break this mechanism. Modification: Make the loops in SocketStartTlsTest and SocketSslEchoTest throw their interrupts instead of silently swallowing them. Result: The tests now responds to timeouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
JUnit relies on interrupts to communicate test timeouts.
When we silently swallow interrupts, we break this mechanism.
Modification:
Make the loops in SocketStartTlsTest and SocketSslEchoTest throw their interrupts instead of silently swallowing them.
Result:
The tests now responds to timeouts.