Fix isOriginForm and isAsteriskForm#12568
Merged
normanmaurer merged 2 commits intonetty:4.1from Jul 8, 2022
Merged
Conversation
These methods would always return false using the previously implementation (URI#getSchemeSpecificPart is documented to *never* return `null`). They also had other implementation errors. Correct these and make sure they at least handle the basic examples provided in RFC 7230. More test cases can be added as needed.
ejona86
reviewed
Jul 7, 2022
Reduce these methods to string comparisons, and add overrides that take strings directly. Use these new methods where we had previously switched to string comparison directly.
ejona86
approved these changes
Jul 8, 2022
Member
|
Thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Jul 8, 2022
Motivation: These methods would always return false using the previously implementation (URI#getSchemeSpecificPart is [documented](https://docs.oracle.com/javase/8/docs/api/java/net/URI.html#getSchemeSpecificPart--) to *never* return `null`). They also had other implementation errors. Modification: Edit methods to conform with RFC 7230. Result: Methods handle the basic examples provided in RFC 7230. More test cases can be added as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
These methods would always return false using the previously implementation (URI#getSchemeSpecificPart is documented to never return
null). They also had other implementation errors.Modification:
Edit methods to conform with RFC 7230.
Result:
Methods handle the basic examples provided in RFC 7230. More test cases can be added as needed.