Allow skip bad entries logging during import#9103
Merged
Conversation
Introduce new import tool option `skip-bad-entries-logging` to allow skip logging of bad entries.
tinwelint
approved these changes
Mar 28, 2017
Member
tinwelint
left a comment
There was a problem hiding this comment.
Great that you also deferred the message string creation, which could be expensive.
| + "about relationships refering to missing nodes. Format errors in input data are " | ||
| + "still treated as errors" ), | ||
| SKIP_BAD_ENTRIES_LOGGING ("skip-bad-entries-logging", Boolean.FALSE, | ||
| "<true/false>", "Whether or not log bad entries detected during import."), |
Member
There was a problem hiding this comment.
Whether or not to skip logging bad entries detected during import
tinwelint
requested changes
Mar 28, 2017
Member
tinwelint
left a comment
There was a problem hiding this comment.
Oh, the little change in the option description
Contributor
Author
|
@tinwelint updated :) |
tinwelint
approved these changes
Mar 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce new import tool option:
skip-bad-entries-loggingthat will allow to skip logging of all bad entries.Default value of new option: false