Skip to content

deps: remove unused deps#4949

Merged
juergba merged 1 commit intomochajs:masterfrom
outsideris:remove-unused-deps
Nov 29, 2022
Merged

deps: remove unused deps#4949
juergba merged 1 commit intomochajs:masterfrom
outsideris:remove-unused-deps

Conversation

@outsideris
Copy link
Copy Markdown
Contributor

@outsideris outsideris commented Nov 23, 2022

Description of the Change

Remove unused 3 dependencies.

  • configstore
    • It introduced in 2137163 . But It appears to have been added by mistake from the beginning.
  • through2
    • It was introduced in a81e555 7 years ago for browserify. But I couldn't find where to use it in this commit.
    • It looks like removed in this commit when we drop the browserify.
  • watchify
    • It was introduced at c04c1d7 . But I couldn't find where to use it in this commit.
    • This is for browserify. Now we don't use browserify anymore.

@outsideris
deps: remove unused deps
bbcbd81 
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris outsideris requested a review from juergba November 27, 2022 08:50
@juergba
Copy link
Copy Markdown
Contributor

juergba commented Nov 27, 2022

@outsideris there is a watch script in package-scripts.js, I suppose it uses watchify for its purpose. I don't think anybody has ever used that script, so could certainly be removed.

@outsideris
Copy link
Copy Markdown
Contributor Author

outsideris commented Nov 28, 2022

@juergba Did you mean here? I think docs.watch doesn't use watchify.

juergba
juergba approved these changes Nov 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outsideris thank you

@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" run-browser-test run browser tests on forked PR if code is safe labels Nov 29, 2022
@github-actions github-actions Bot removed the run-browser-test run browser tests on forked PR if code is safe label Nov 29, 2022
@juergba juergba merged commit fc4ac58 into mochajs:master Nov 29, 2022
@juergba juergba added this to the next milestone Nov 29, 2022
lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
@outsideris
chore(devDeps): remove unused depedencies (mochajs#4949)
700a97d 
Signed-off-by: Outsider <outsideris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@juergba juergba juergba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.

Projects

None yet

Milestone

v10.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@outsideris @juergba