Recursively check unique pkg names against existing imports#186
Merged
sudo-suhas merged 1 commit intomainfrom Nov 20, 2022
Merged
Recursively check unique pkg names against existing imports#186sudo-suhas merged 1 commit intomainfrom
sudo-suhas merged 1 commit intomainfrom
Conversation
When we generate a unique name for pkg a on conflict with pkg b, the new name could already be in use for pkg c. So recursively check each unique name against existing imports before setting it.
Collaborator
Author
breml
approved these changes
Nov 18, 2022
Contributor
breml
left a comment
There was a problem hiding this comment.
LGTM, but I think the algorithm for selecting an alias could be simplified. Because we are talking about generated code, I would argue, that this might be worth the price for the reduced readability of the generated code (see my inline comment for details).
Collaborator
Author
|
Released in v0.3.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we generate a unique name for pkg a on conflict with pkg b, the new name could already be in use for pkg c. So recursively check each unique name against existing imports before setting it.
Closes #184
/cc @cldmstr