Fix for issue #1192: NotSerializableException with AssumptionViolatedException#1654
Merged
kcooney merged 4 commits intoJan 11, 2021
Merged
Conversation
…n writeObject serialization of AssumptionViolatedException
kcooney
approved these changes
Jan 3, 2021
marcphilipp
approved these changes
Jan 4, 2021
Member
|
@kcooney @stefanbirkner I added this to the 4.13.2 milestone. Any objections? |
stefanbirkner
approved these changes
Jan 6, 2021
Give assertion methods shorter names. Co-authored-by: Stefan Birkner <github@stefan-birkner.de>
Fix compile errors caused by previous commit.
This was referenced Mar 11, 2021
This was referenced Mar 18, 2021
This was referenced Apr 22, 2021
This was referenced May 11, 2021
jc7020
reviewed
Jan 24, 2022
jc7020
left a comment
There was a problem hiding this comment.
src/test/resources/org/junit/assumptionViolatedExceptionWithoutValueAndMatcherCanBeReserialized_v4_13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #1192: NotSerializableException with AssumptionViolatedException
This PR resolves issues where AssumptionViolatedExceptions can't be serialized due to a non-serializable Matcher and/or value object.
I've added tests to make sure serialization is compatible with previous versions and most of the 'magic' should be documented properly.
Cheers!
Riccardo Sirchia