Update travis to pass on all supported python versions#194
Merged
jamesls merged 6 commits intojmespath:developfrom Feb 24, 2020
Merged
Update travis to pass on all supported python versions#194jamesls merged 6 commits intojmespath:developfrom
jamesls merged 6 commits intojmespath:developfrom
Conversation
Looking to drop 26/33 soon but for now we just need to get travis back up and running.
We should come back and improve these, but for now this brings back the same behavior for 3.8 as the other python versions.
These are taking orders of magnitude longer, and I verified that they do pass with smaller example counts. I'd rather disable this for 3.8 than to lower the num examples across all python versions.
Codecov Report
@@ Coverage Diff @@
## develop #194 +/- ##
===========================================
+ Coverage 98.19% 98.23% +0.03%
===========================================
Files 14 14
Lines 1441 1472 +31
===========================================
+ Hits 1415 1446 +31
Misses 26 26
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the follow up for #188 is to get travis passing again on all supported python versions. To fix this I locked the old python versions to
trusty. I also had to upgrade some of the test deps to newer versions for py38. Hypothesis also needed some config changes due to the health checks now failing, and it fails on travis because it stalls for more than 10 minutes. I'd like to circle back on these fixtures and improve them but for now this just brings back everything to a passing state.