Allow attributes valid in html when converting#1648
Merged
jhy merged 4 commits intojhy:masterfrom Oct 6, 2021
jairamc:bug/html-dom-with-accent-chars
Merged
Allow attributes valid in html when converting#1648jhy merged 4 commits intojhy:masterfrom jairamc:bug/html-dom-with-accent-chars
jhy merged 4 commits intojhy:masterfrom
jairamc:bug/html-dom-with-accent-chars
Conversation
When parsing and converting an html document, the "syntax" was hard-coded to xml. This PR checks the document type of the output document and uses that to determine which attributes are valid.
jhy
reviewed
Sep 30, 2021
On windows, DOM will write newlines as \r\n
To preserve backcompat
Owner
|
Thanks! I updated the commit a little to preserve the current public constructor of the W3CBuilder, to maintain backcompat. And to reuse the existing ownerDocument scan up, and to add a negative (XML syntax) check. |
This was referenced May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing and converting an html document, the "syntax" was hard-coded to xml. This PR checks the document type of the output document and uses that to determine which attributes are valid.
Changes for #1647