deprecator.rb: fix typo for --serve command#6229
Merged
jekyllbot merged 5 commits intojekyll:masterfrom Jul 18, 2017
Merged
Conversation
The first warning is short enough such that it wont wrap to the next line. Hence the subsequent message does not need a topic label.
ghost
reviewed
Jul 18, 2017
ghost
left a comment
There was a problem hiding this comment.
eh, fine by me. it's basically just a matter of personal preference since i'm pretty sure we use both styles within the codebase already
Member
|
I don't mind, but it might be worth not making changes that would muddy |
Member
Author
|
hmm, okay.. I'll use this PR to correct the typo and remove just the |
Member
Author
|
Since jekyllbot doesn't squash and merge, I'll manually rebase once the new diff is approved.. |
Member
|
@jekyllbot: merge +bug |
Member
Author
|
Well I'll be a....... JekyllBot does squash and merge.. Cool! |
Member
|
I forgot about that 😜👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly a personal preference, not sure how it affects overall performance
/cc @pathawks