Skip to content

Ignore final newline in folded YAML string#6054

Merged
jekyllbot merged 3 commits intojekyll:masterfrom
ashmaroli:yaml-fold-newline
Jul 18, 2017
Merged

Ignore final newline in folded YAML string#6054
jekyllbot merged 3 commits intojekyll:masterfrom
ashmaroli:yaml-fold-newline

Conversation

@ashmaroli
Copy link
Copy Markdown
Member

@ashmaroli ashmaroli commented Apr 28, 2017

before: {{ site.description }} =>

"Write an awesome description for your new site here. You can edit this line in _config.yml. It
will appear in your document head meta (for Google search results) and in your feed.xml site
description./n"

after: {{ site.description }} =>

"Write an awesome description for your new site here. You can edit this line in _config.yml. It
will appear in your document head meta (for Google search results) and in your feed.xml site
description."

@ashmaroli
ignore final newline in folded YAML string
1390666 
  before: {{ site.description }} =>
	  "Write an awesome description for your new site here. You can
	  edit this line in _config.yml. It will appear in your document
	  head meta (for Google search results) and in your feed.xml site
	  description./n"

   after: {{ site.description }} =>
	  "Write an awesome description for your new site here. You can
	  edit this line in _config.yml. It will appear in your document
	  head meta (for Google search results) and in your feed.xml site
	  description."
@ashmaroli
Copy link
Copy Markdown
Member Author

ashmaroli commented Apr 28, 2017

/cc @jekyll/ecosystem

parkr
parkr approved these changes May 10, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Should we also test that the new site's site.config["description"] doesn't have a trailing newline?

@ashmaroli
Copy link
Copy Markdown
Member Author

ashmaroli commented May 10, 2017

Should we also test that the new site's site.config["description"] doesn't have a trailing newline?

I think its implied..

@parkr
Copy link
Copy Markdown
Member

parkr commented May 10, 2017

I think its implied..

That's the point... I don't want it to be implicit, I think if we're making this change we should explicitly test it.

@DirtyF
Copy link
Copy Markdown
Member

DirtyF commented Jun 21, 2017 •
edited
Loading

@ashmaroli do you intend to test for a trailing newline here?

@ashmaroli
Copy link
Copy Markdown
Member Author

ashmaroli commented Jun 22, 2017

do you intend to test for a trailing newline here?

Sorry, I forgot all about this. Thanks for reminding.. Will push a commit shortly.

@ashmaroli

This comment has been minimized.

Sign in to view
@DirtyF
Copy link
Copy Markdown
Member

DirtyF commented Jul 18, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 026f828 into jekyll:master Jul 18, 2017
jekyllbot added a commit that referenced this pull request Jul 18, 2017
@jekyllbot
Update history to reflect merge of #6054 [ci skip]
2b28f9f
@ashmaroli ashmaroli deleted the yaml-fold-newline branch July 18, 2017 07:31
DirtyF added a commit that referenced this pull request Sep 30, 2018
@DirtyF
Add links to YAML cheatsheets
63deec3 
Fix #6054
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DirtyF DirtyF DirtyF approved these changes

@parkr parkr parkr approved these changes

@pathawks pathawks pathawks approved these changes

Assignees

@pathawks pathawks

Labels

frozen-due-to-age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ashmaroli @parkr @DirtyF @pathawks @jekyllbot