Skip to content

Use vswhere to find vcvarsall.bat#11

Merged
ilammy merged 8 commits intoilammy:masterfrom
aminya:vswhere
Sep 23, 2020
Merged

Use vswhere to find vcvarsall.bat#11
ilammy merged 8 commits intoilammy:masterfrom
aminya:vswhere

Conversation

@aminya
Copy link
Copy Markdown
Contributor

@aminya aminya commented Sep 21, 2020

The windows images provided by GitHub have a native program called vswhere, which can be used to find vcvarsall.bat.

@aminya
Copy link
Copy Markdown
Contributor Author

aminya commented Sep 23, 2020

@ilammy Could you take a look at this?

Copy link
Copy Markdown
Owner

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aminya, I'm sorry for late review :( $dayjob ate all of my brain and asks for seconds.

Anyway, overall I like the change! 👍 It can be made a bit more resilient, but otherwise it's good.

Comment thread index.js Outdated
Comment thread index.js Outdated
@aminya
Copy link
Copy Markdown
Contributor Author

aminya commented Sep 23, 2020

@aminya, I'm sorry for late review :( $dayjob ate all of my brain and asks for seconds.

Anyway, overall I like the change! 👍 It can be made a bit more resilient, but otherwise it's good.

No worries! Thank you! I applied the changes

Copy link
Copy Markdown
Owner

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! ❤️

@ilammy ilammy merged commit 4b3ec49 into ilammy:master Sep 23, 2020
@aminya
Copy link
Copy Markdown
Contributor Author

aminya commented Sep 23, 2020

Thanks for merging!

@ilammy ilammy mentioned this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants