Skip to content

(docs) More prominent list of supported languages#2309

Merged
joshgoebel merged 11 commits intohighlightjs:masterfrom
codingthat:more-prominent-list
Dec 7, 2019
Merged

(docs) More prominent list of supported languages#2309
joshgoebel merged 11 commits intohighlightjs:masterfrom
codingthat:more-prominent-list

Conversation

@codingthat
Copy link
Copy Markdown
Contributor

@codingthat codingthat commented Dec 4, 2019

I didn't see the list in the readme right away. It's a common thing to need to refer to, so it makes sense to make it a bit more visible, even if we want to collapse it by default to make the rest of the document more readable.

Resolves #2288

With a plain paragraph and tiny drop-down arrow, it's easy to miss, and also harder to link to well.
Markdown syntax was showing through because this is not an .md file. Also, link directly to new anchor for convenience.
@joshgoebel
Copy link
Copy Markdown
Member

What do you think about removing summary/details and just including the list inline? I think that would help even further.

@joshgoebel joshgoebel changed the title More prominent list (simple doc changes) (docs) More prominent list of supported languages Dec 4, 2019
@codingthat
Copy link
Copy Markdown
Contributor Author

codingthat commented Dec 4, 2019

@yyyc514 I'm up for that, but since it used to be that way, I assumed it changed from that for a reason. This PR was trying to stay in line with the collapsing of it while still helping its visibility a bit.

(Sorry, I'm an outsider here. I hadn't realized there was all this previous discussion about it, e.g. #2096 . Maybe this would work as an interim solution, until it can be decided whether to move everything back to its own file again?)

@Samoxive
Copy link
Copy Markdown

Samoxive commented Dec 4, 2019

This seems like a good middle way, keeping the list inline may be too annoying for people with small resolution screens or mobile readers.

@joshgoebel
Copy link
Copy Markdown
Member

@codingthat If you want a mention in the changelog, please add one.

@joshgoebel joshgoebel self-requested a review December 5, 2019 17:00
@joshgoebel joshgoebel added this to the 9.17 milestone Dec 6, 2019
@joshgoebel joshgoebel merged commit 1c4110f into highlightjs:master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The supported languages list is hard to spot and read

3 participants