fix(kotlin): fix termination of """ string literals#2295
Merged
joshgoebel merged 3 commits intohighlightjs:masterfrom Nov 22, 2019
Merged
fix(kotlin): fix termination of """ string literals#2295joshgoebel merged 3 commits intohighlightjs:masterfrom
joshgoebel merged 3 commits intohighlightjs:masterfrom
Conversation
Member
joshgoebel
commented
Nov 21, 2019
- Properly handles cases: like """ends in a "quoted string""""
- Closes (kotlin) Incorrect handling of strings with triple quotes #2280.
- Properly handles cases: like """ends in a "quoted string"""" - Closes highlightjs#2280.
Collaborator
|
I have had a look into Kotlin grammar (https://kotlinlang.org/docs/reference/grammar.html). The relevant parts are: It seems that |
Member
Author
Collaborator
|
Yeah, I played around a bit and looks like you're right. We need the rightmost match. |
egor-rogov
approved these changes
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
