(go) Fix escaped character literals#2266
Merged
joshgoebel merged 2 commits intohighlightjs:masterfrom Nov 12, 2019
Merged
Conversation
joshgoebel
reviewed
Nov 10, 2019
Member
|
I’ll review all these PRs more carefully tomorrow. |
Member
|
Any chance you have time/interest to look into the 6-7 other languages we're using this and see if they likewise suffer from the same issue? One could imagine a language where \ wasn't valid so this MIGHT be a reasonable regex... |
joshgoebel
approved these changes
Nov 12, 2019
Member
joshgoebel
left a comment
There was a problem hiding this comment.
Please add Changelog entry.
Contributor
Author
I'm traveling for the next two weeks so probably not for a bit. But maybe if I get bored on the plane.
Done |
joshgoebel
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1411