Skip to content

better error when language is not found#2236

Merged
joshgoebel merged 4 commits intohighlightjs:masterfrom
joshgoebel:better_errors_when_language_missing
Oct 30, 2019
Merged

better error when language is not found#2236
joshgoebel merged 4 commits intohighlightjs:masterfrom
joshgoebel:better_errors_when_language_missing

Conversation

@joshgoebel
Copy link
Copy Markdown
Member

Closes #1569.

@joshgoebel joshgoebel added this to the 9.16.1 milestone Oct 29, 2019
@joshgoebel joshgoebel requested a review from egor-rogov October 29, 2019 13:48
@joshgoebel joshgoebel added parser enhancement An enhancement or new feature labels Oct 29, 2019
@egor-rogov
Copy link
Copy Markdown
Collaborator

Do you really want to change developer.html like this?
Everything else is fine.

@joshgoebel
Copy link
Copy Markdown
Member Author

LOL, I do not. I will pull that out.

This reverts commit a26331d.
@joshgoebel joshgoebel merged commit b17e4c1 into highlightjs:master Oct 30, 2019
@joshgoebel joshgoebel deleted the better_errors_when_language_missing branch December 6, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show/log an error if the user requests a valid language that isn't currently available

2 participants