Skip to content

fix: toolkit type fixes and doc improvements - #1992

Merged
acao merged 2 commits into
mainfrom
fix/toolkit-types-docs
Oct 29, 2021
Merged

fix: toolkit type fixes and doc improvements#1992
acao merged 2 commits into
mainfrom
fix/toolkit-types-docs

Conversation

@acao

@acao acao commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

fixes #1989

  • remove subscriptions-transport-ws from the types.ts file, oops!
  • re-enable deploy previews with a simple consuming typescript + webpack build so we catch those errors earlier on!
  • improve the docs for @graphiql/toolkit createFetcher()
  • legacyWsClient makes more sense than legacyClient

@changeset-bot

changeset-bot Bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c8ebb19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1992 (2bac7b1) into main (2d91916) will increase coverage by 0.75%.
The diff coverage is 70.09%.

❗ Current head 2bac7b1 differs from pull request most recent head c8ebb19. Consider uploading reports for the commit c8ebb19 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1992      +/-   ##
==========================================
+ Coverage   65.70%   66.46%   +0.75%     
==========================================
  Files          85       86       +1     
  Lines        5106     5144      +38     
  Branches     1631     1641      +10     
==========================================
+ Hits         3355     3419      +64     
+ Misses       1747     1721      -26     
  Partials        4        4
Impacted Files Coverage Δ
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 51.78% <46.66%> (-7.79%) ⬇️
packages/graphiql/src/utility/HistoryStore.ts 62.26% <62.26%> (ø)
packages/graphiql/src/components/QueryHistory.tsx 73.91% <76.47%> (+6.69%) ⬆️
...iql/src/components/DocExplorer/MarkdownContent.tsx 100.00% <100.00%> (ø)
packages/graphiql/src/components/GraphiQL.tsx 58.34% <100.00%> (+0.83%) ⬆️
...ql-language-service-server/src/MessageProcessor.ts 66.66% <100.00%> (+6.38%) ⬆️
...hql-language-service-server/src/findGraphQLTags.ts 67.64% <100.00%> (+7.00%) ⬆️
...raphql-language-service-server/src/GraphQLCache.ts 52.25% <0.00%> (+0.60%) ⬆️
packages/graphiql/src/utility/QueryStore.ts 42.85% <0.00%> (+2.04%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8577c7e...c8ebb19. Read the comment docs.

@github-actions

github-actions Bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://617bb3884c9128a42c02892a--graphiql-test.netlify.app

@github-actions
github-actions Bot temporarily deployed to graphiql-1 October 29, 2021 08:30 Inactive
@github-actions

github-actions Bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://617bb3d397042db2d2c0b528--monaco-graphql.netlify.app

@github-actions
github-actions Bot temporarily deployed to monaco-graphql October 29, 2021 08:30 Inactive
@acao
acao force-pushed the fix/toolkit-types-docs branch from 2bac7b1 to 7aa38c5 Compare October 29, 2021 08:32
@github-actions

github-actions Bot commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://617bb3ac6ee0abb3d8178bea--graphiql-webpack-example.netlify.app

@github-actions
github-actions Bot temporarily deployed to graphiql-webpack October 29, 2021 08:35 Inactive
@github-actions
github-actions Bot temporarily deployed to graphiql-1 October 29, 2021 08:35 Inactive
@github-actions
github-actions Bot temporarily deployed to monaco-graphql October 29, 2021 08:37 Inactive
@acao
acao force-pushed the fix/toolkit-types-docs branch from 7aa38c5 to c8ebb19 Compare October 29, 2021 08:37
@github-actions
github-actions Bot temporarily deployed to graphiql-1 October 29, 2021 08:40 Inactive
@github-actions
github-actions Bot temporarily deployed to graphiql-webpack October 29, 2021 08:41 Inactive
@github-actions
github-actions Bot temporarily deployed to monaco-graphql October 29, 2021 08:41 Inactive
@acao
acao merged commit 1f9f31c into main Oct 29, 2021
@acao
acao deleted the fix/toolkit-types-docs branch October 29, 2021 08:48
@github-actions github-actions Bot mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incomplete TypeScript typings in @graphiql/toolkit@0.3.0

1 participant

@acao