Drop pre-JDK 11 logic from Refaster's Inliner class#3441
Closed
Stephan202 wants to merge 1 commit intogoogle:masterfrom
Closed
Drop pre-JDK 11 logic from Refaster's Inliner class#3441Stephan202 wants to merge 1 commit intogoogle:masterfrom
Inliner class#3441Stephan202 wants to merge 1 commit intogoogle:masterfrom
Conversation
Contributor
Author
cushon
approved these changes
Sep 11, 2022
Contributor
Author
|
My colleagues @Badbond and @nathankooij pointed out that strictly speaking this PR came too early, as JDK-8193367 was fixed in JDK 11.0.9, meaning that with this change Error Prone 2.16 is not compatible with JDK 11.0.8 and prior. This impacted us when updating our fork, as Jitpack by default uses Java 11.0.2. That said, the workaround was not hard. Since JDK 11.0.9 was released almost two years ago, this incompatibility might not be an issue for most/all users, but if reports do come in, perhaps this change should be reverted for now. @cushon let me know if you'd like me to open a PR for that. |
Collaborator
|
Thanks @Stephan202, leaving this in for now and waiting to see if it causes any issues in practice SGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.