Remove duplicate TypesWithUndefinedEquality#SPARSE_ARRAY entry#3110
Closed
rickie wants to merge 3 commits intogoogle:masterfrom
Closed
Remove duplicate TypesWithUndefinedEquality#SPARSE_ARRAY entry#3110rickie wants to merge 3 commits intogoogle:masterfrom
TypesWithUndefinedEquality#SPARSE_ARRAY entry#3110rickie wants to merge 3 commits intogoogle:masterfrom
Conversation
rickie
commented
Apr 14, 2022
| @@ -24,25 +24,21 @@ | |||
|
|
|||
| /** Enumerates types which have poorly-defined behaviour for equals. */ | |||
| public enum TypesWithUndefinedEquality { | |||
Contributor
Author
There was a problem hiding this comment.
The following (somewhat hacky, likely Linux-only) script verifies that this PR does not introduce additional changes:
#!/usr/bin/env bash
set -e -u -o pipefail
normalize() {
local rev="${1}"
git show "${rev}:core/src/main/java/com/google/errorprone/bugpatterns/TypesWithUndefinedEquality.java" \
| grep -Pzo '(?<=LONG_SPARSE_ARRAY\()[^)]+' | grep -Pao '[\w.]+' | sort -u
git show "${rev}:core/src/main/java/com/google/errorprone/bugpatterns/TypesWithUndefinedEquality.java" \
| grep -Pzo '(?<=SPARSE_ARRAY\()[^)]+' | grep -Pao '[\w.]+' | sort -u
git show "${rev}:core/src/main/java/com/google/errorprone/bugpatterns/TypesWithUndefinedEquality.java" \
| grep -Po '[A-Z_]+\(' | sort -u
}
diff -u <(normalize master) <(normalize HEAD)
| @@ -24,25 +24,21 @@ | |||
|
|
|||
| /** Enumerates types which have poorly-defined behaviour for equals. */ | |||
| public enum TypesWithUndefinedEquality { | |||
Contributor
Author
There was a problem hiding this comment.
Should we add java.lang.Object to the TypesWithUndefinedEquality enum?
cushon
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
androidx.collection.SparseArrayCompatwas listed twice.While there, sort the enum elements and type names.