Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "webpack": "5.105.4", | ||
| "webpack-cli": "6.0.1", | ||
| "@babel/preset-react": "7.23.3", | ||
| "@sentry/webpack-plugin": "5.1.1" |
There was a problem hiding this comment.
q: Are we testing on pinned versions intentionally?
There was a problem hiding this comment.
Yes mainly because we're snapshotting the output. Don't really want all the tests failing when any bundler changes their output. Probably less of an issue with webpack as it doesn't change mutch.
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 5.1.1 | 5.2.0 | ## [v5.2.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#520) ##### New Features ✨ - (core) Pass `mapDir` to `rewriteSourcesHook` by [@chargome](https://github.com/chargome) in [#908](getsentry/sentry-javascript-bundler-plugins#908) - Use `crypto.randomUUID` rather than `uuid` by [@timfish](https://github.com/timfish) in [#892](getsentry/sentry-javascript-bundler-plugins#892) ##### Bug Fixes 🐛 - (core) Conditionally add tracing headers by [@chargome](https://github.com/chargome) in [#907](getsentry/sentry-javascript-bundler-plugins#907) - (e2e-tests) Pin axios to 1.13.5 to avoid compromised 1.14.1 by [@andreiborza](https://github.com/andreiborza) in [#906](getsentry/sentry-javascript-bundler-plugins#906) - (rollup) Make rollup an optional peer dependency by [@andreiborza](https://github.com/andreiborza) in [#913](getsentry/sentry-javascript-bundler-plugins#913) - Add missing webpack5 entrypoint in webpack-plugin by [@brunodccarvalho](https://github.com/brunodccarvalho) in [#905](getsentry/sentry-javascript-bundler-plugins#905) ##### Internal Changes 🔧 - (deps) Bump vulnerable webpack version by [@chargome](https://github.com/chargome) in [#909](getsentry/sentry-javascript-bundler-plugins#909) - (tests) Use deterministic debugids by [@chargome](https://github.com/chargome) in [#912](getsentry/sentry-javascript-bundler-plugins#912) - Add esbuild integration tests by [@timfish](https://github.com/timfish) in [#911](getsentry/sentry-javascript-bundler-plugins#911) - Vite integration tests by [@timfish](https://github.com/timfish) in [#899](getsentry/sentry-javascript-bundler-plugins#899) - Webpack integration tests by [@timfish](https://github.com/timfish) in [#904](getsentry/sentry-javascript-bundler-plugins#904) - Isolate integration test package installs by [@timfish](https://github.com/timfish) in [#902](getsentry/sentry-javascript-bundler-plugins#902) - Pin GitHub Actions to full-length commit SHAs by [@joshuarli](https://github.com/joshuarli) in [#900](getsentry/sentry-javascript-bundler-plugins#900) - Rollup integration tests by [@timfish](https://github.com/timfish) in [#897](getsentry/sentry-javascript-bundler-plugins#897) - New integration tests by [@timfish](https://github.com/timfish) in [#896](getsentry/sentry-javascript-bundler-plugins#896) - Remove lerna by [@timfish](https://github.com/timfish) in [#895](getsentry/sentry-javascript-bundler-plugins#895) - Migrate to Vitest by [@timfish](https://github.com/timfish) in [#894](getsentry/sentry-javascript-bundler-plugins#894)
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 5.1.1 | 5.2.0 | ## [v5.2.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#520) ##### New Features ✨ - (core) Pass `mapDir` to `rewriteSourcesHook` by [@chargome](https://github.com/chargome) in [#908](getsentry/sentry-javascript-bundler-plugins#908) - Use `crypto.randomUUID` rather than `uuid` by [@timfish](https://github.com/timfish) in [#892](getsentry/sentry-javascript-bundler-plugins#892) ##### Bug Fixes 🐛 - (core) Conditionally add tracing headers by [@chargome](https://github.com/chargome) in [#907](getsentry/sentry-javascript-bundler-plugins#907) - (e2e-tests) Pin axios to 1.13.5 to avoid compromised 1.14.1 by [@andreiborza](https://github.com/andreiborza) in [#906](getsentry/sentry-javascript-bundler-plugins#906) - (rollup) Make rollup an optional peer dependency by [@andreiborza](https://github.com/andreiborza) in [#913](getsentry/sentry-javascript-bundler-plugins#913) - Add missing webpack5 entrypoint in webpack-plugin by [@brunodccarvalho](https://github.com/brunodccarvalho) in [#905](getsentry/sentry-javascript-bundler-plugins#905) ##### Internal Changes 🔧 - (deps) Bump vulnerable webpack version by [@chargome](https://github.com/chargome) in [#909](getsentry/sentry-javascript-bundler-plugins#909) - (tests) Use deterministic debugids by [@chargome](https://github.com/chargome) in [#912](getsentry/sentry-javascript-bundler-plugins#912) - Add esbuild integration tests by [@timfish](https://github.com/timfish) in [#911](getsentry/sentry-javascript-bundler-plugins#911) - Vite integration tests by [@timfish](https://github.com/timfish) in [#899](getsentry/sentry-javascript-bundler-plugins#899) - Webpack integration tests by [@timfish](https://github.com/timfish) in [#904](getsentry/sentry-javascript-bundler-plugins#904) - Isolate integration test package installs by [@timfish](https://github.com/timfish) in [#902](getsentry/sentry-javascript-bundler-plugins#902) - Pin GitHub Actions to full-length commit SHAs by [@joshuarli](https://github.com/joshuarli) in [#900](getsentry/sentry-javascript-bundler-plugins#900) - Rollup integration tests by [@timfish](https://github.com/timfish) in [#897](getsentry/sentry-javascript-bundler-plugins#897) - New integration tests by [@timfish](https://github.com/timfish) in [#896](getsentry/sentry-javascript-bundler-plugins#896) - Remove lerna by [@timfish](https://github.com/timfish) in [#895](getsentry/sentry-javascript-bundler-plugins#895) - Migrate to Vitest by [@timfish](https://github.com/timfish) in [#894](getsentry/sentry-javascript-bundler-plugins#894)

This PR follows #899 and the previous PRs by adding webpack tests