Don't set poller.fd twice in newFdPoller#406
Merged
nshalman merged 2 commits intofsnotify:mainfrom Jan 19, 2022
Merged
Conversation
Contributor
|
I thought the tests would run when I did that... 😕 |
Contributor
In newEmptyPoller when creating the poller using newEmptyPoller(fd), the fd field of the poller instance is already set. There is no need to set it again.
5fcbb4d to
7193483
Compare
nshalman
approved these changes
Jan 16, 2022
Contributor
nshalman
left a comment
There was a problem hiding this comment.
This makes sense to me. Being extra cautious and requesting @shogo82148 to confirm too.
Contributor
|
Having stared at this enough times and seeing the tests pass, I'm satisfied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
newEmptyPollerwhen creating thepollerusingnewEmptyPoller(fd), thefdfield is already set. There is no need to set it again.