jest-matcher-utils: Add color options to matcherHint#8795
Merged
pedrottimark merged 5 commits intojestjs:masterfrom Aug 9, 2019
Merged
jest-matcher-utils: Add color options to matcherHint#8795pedrottimark merged 5 commits intojestjs:masterfrom
pedrottimark merged 5 commits intojestjs:masterfrom
Conversation
Contributor
Author
|
In the prototype hints for snapshot tests with |
SimenB
reviewed
Aug 8, 2019
SimenB
approved these changes
Aug 8, 2019
jeysal
added a commit
to felipepastorelima/jest
that referenced
this pull request
Aug 11, 2019
* upstream/master: expect: Display equal values for ReturnedWith similar to CalledWith (jestjs#8791) Clearer messages for Node assert errors (jestjs#8792) use babel-plugin-replace-ts-export-assignment package (jestjs#8805) jest-matcher-utils: Add color options to matcherHint (jestjs#8795) chore: Make sure copyright header comment includes license (jestjs#8783)
This was referenced Dec 31, 2019
This was referenced Jan 7, 2020
This was referenced Jan 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
precision,n,hintBaseline hint at left and prototype hint at right
Any color comments welcome now or we can discuss details in following pull requests
Test plan
Added 3 tests for
expectedColor,receivedColor,secondArgumentColor