Fix babel-plugin-jest-hoist: getting full list of whitelisted globals#8429
Merged
SimenB merged 2 commits intojestjs:masterfrom May 7, 2019
Merged
Fix babel-plugin-jest-hoist: getting full list of whitelisted globals#8429SimenB merged 2 commits intojestjs:masterfrom
SimenB merged 2 commits intojestjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8429 +/- ##
=======================================
Coverage 62.32% 62.32%
=======================================
Files 266 266
Lines 10733 10733
Branches 2614 2615 +1
=======================================
Hits 6689 6689
Misses 3461 3461
Partials 583 583
Continue to review full report at Codecov.
|
This was referenced Oct 10, 2019
This was referenced Nov 1, 2019
This was referenced Dec 31, 2019
This was referenced Jan 7, 2020
This was referenced Jan 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #8427
Summary
As mentioned in #8427, Node v12 has changed the enumerability of
global.processandglobal.Buffer, thus the list of allowed globals became much shorter. I believe, that suggested change will improve the testing experience because it provides more complete list of available globals that can be safely used in hoisted mocks.Test plan
I ran the e2e test for this plugin and it was all green.
P.S. I signed the CLA.