Skip to content

Chore: Simplify internal no-invalid-meta rule#14842

Merged
bmish merged 1 commit intoeslint:masterfrom
bmish:simplify-no-invalid-meta
Jul 29, 2021
Merged

Chore: Simplify internal no-invalid-meta rule#14842
bmish merged 1 commit intoeslint:masterfrom
bmish:simplify-no-invalid-meta

Conversation

@bmish
Copy link
Copy Markdown
Member

@bmish bmish commented Jul 27, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

What changes did you make? (Give an overview)

A few cases in our internal rule no-invalid-meta can be removed and replaced by:

And we can also enable a few other useful rules:

Follow-up to these other PRs to switch us from custom internal lint rules to public rules:

CC: @aladdin-add

Is there anything you'd like reviewers to focus on?

No.

@eslint-github-bot eslint-github-bot Bot added the triage An ESLint team member will look at this issue soon label Jul 27, 2021
@bmish bmish force-pushed the simplify-no-invalid-meta branch from 9f348f2 to 8733c21 Compare July 27, 2021 21:44
Copy link
Copy Markdown
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add requested a review from mdjermanovic July 28, 2021 01:03
Copy link
Copy Markdown
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@nzakas nzakas added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Jul 29, 2021
@bmish bmish merged commit ed007c8 into eslint:master Jul 29, 2021
@bmish bmish deleted the simplify-no-invalid-meta branch July 29, 2021 18:11
@eslint-github-bot eslint-github-bot Bot locked and limited conversation to collaborators Jan 26, 2022
@eslint-github-bot eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants