Fix: ignore lines with empty elements (fixes #12756)#14837

Merged

btmills merged 3 commits intoeslint:masterfrom

boutahlilsoufiane:issue12756

Jul 30, 2021

Contributor

boutahlilsoufiane commented Jul 25, 2021 •

edited

Loading

Prerequisites checklist

I have read the contributing guidelines.
The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Bug fix

What changes did you make? (Give an overview)

Fix the issue here: #12756

This PR fixes a bug in the rule comma-style, it ignores lines that are only made of empty elements.
This is an example:

const [
    ,
    a,
    b,
] = arr;

Is there anything you'd like reviewers to focus on?

No.

eslint-github-bot Bot added the triage label

eslint-github-bot Bot commented Jul 25, 2021

Hi @boutahlilsoufiane!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

3 similar comments

eslint-github-bot Bot commented Jul 25, 2021

Hi @boutahlilsoufiane!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

eslint-github-bot Bot commented Jul 25, 2021

Hi @boutahlilsoufiane!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

eslint-github-bot Bot commented Jul 25, 2021

Hi @boutahlilsoufiane!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

boutahlilsoufiane changed the title ~~Fix: Ignore any lines that are only made of empty elements (fixes #12…~~ Fix: Ignore lines with empty elements (fixes #12…

eslint-github-bot Bot commented Jul 25, 2021

Hi @boutahlilsoufiane!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

boutahlilsoufiane changed the title ~~Fix: Ignore lines with empty elements (fixes #12…~~ Fix: ignore lines with empty elements (fixes #12…

eslint-github-bot Bot commented Jul 25, 2021

Hi @boutahlilsoufiane!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here


          Fix: ignore lines with empty elements (fixes eslint#12756)

faf9392

boutahlilsoufiane force-pushed the issue12756 branch from bac30b0 to faf9392 Compare

July 25, 2021 19:26

eslint-github-bot Bot commented Jul 25, 2021

Hi @boutahlilsoufiane!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The issue reference must be formatted as follows:

If the pull request addresses an issue, then the issue number should be mentioned at the end. If the commit doesn't completely fix the issue, then use (refs #1234) instead of (fixes #1234).

Here are some good commit message summary examples:
```
Build: Update Travis to only test Node 0.10 (refs #734)
Fix: Semi rule incorrectly flagging extra semicolon (fixes #840)
Upgrade: Esprima to 1.2, switch to using comment attachment (fixes #730)
```

Read more about contributing to ESLint here


          Fix: ignore lines with empty elements (fixes eslint#12756)

bc349f6

boutahlilsoufiane changed the title ~~Fix: ignore lines with empty elements (fixes #12…~~ Fix: ignore lines with empty elements (fixes eslint#12756)

eslint-github-bot Bot commented Jul 25, 2021

Hi @boutahlilsoufiane!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

The issue reference must be formatted as follows:

If the pull request addresses an issue, then the issue number should be mentioned at the end. If the commit doesn't completely fix the issue, then use (refs #1234) instead of (fixes #1234).

Here are some good commit message summary examples:
```
Build: Update Travis to only test Node 0.10 (refs #734)
Fix: Semi rule incorrectly flagging extra semicolon (fixes #840)
Upgrade: Esprima to 1.2, switch to using comment attachment (fixes #730)
```

Read more about contributing to ESLint here

nzakas changed the title ~~Fix: ignore lines with empty elements (fixes eslint#12756)~~ Fix: ignore lines with empty elements (fixes #12756)

nzakas reviewed

View reviewed changes

Member

nzakas left a comment

Thanks for picking this up. The change looks good, just a note on the tests.

tests/lib/rules/comma-style.js Outdated

nzakas added accepted bug rule and removed triage labels


          Fix: ignore lines with empty elements (fixes eslint#12756)

629fb35

boutahlilsoufiane force-pushed the issue12756 branch from 23c02f5 to 629fb35 Compare

July 29, 2021 12:28

boutahlilsoufiane requested a review from nzakas

July 29, 2021 12:36

nzakas approved these changes

View reviewed changes

Member

nzakas left a comment

LGTM. I’d just like another set of eyes before merging.

btmills approved these changes

View reviewed changes

btmills merged commit d7dc07a into eslint:master

boutahlilsoufiane deleted the issue12756 branch

July 31, 2021 19:12

eslint-github-bot Bot locked and limited conversation to collaborators

eslint-github-bot Bot added the archived due to age label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accepted archived due to age bug rule