Conversation
bmish
approved these changes
Jul 20, 2021
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
Should we also update line 38, and is there an overview of breaking changes in v2?
Member
|
I was looking to find out if there were any breaking changes, it's hard to tell but doesn't look like it: https://github.com/actions/setup-node/releases |
Member
|
I found a question about v2 breaking changes (actions/setup-node#223), as it seems that an overview of v2 is missing. By actions/setup-node#223 (comment), it does look like there were no breaking changes. |
aladdin-add
approved these changes
Jul 21, 2021
Contributor
Author
Yes, I missed that one. There aren't any breaking changes, we can update safely. |
nzakas
approved these changes
Jul 22, 2021
bmish
added a commit
to bmish/eslint
that referenced
this pull request
Jul 27, 2021
* master: Chore: Adopt `eslint-plugin/require-meta-docs-url` rule internally (eslint#14823) Docs: New syntax issue template (eslint#14826) Chore: assertions on reporting loc in `unicode-bom` (refs eslint#12334) (eslint#14809) Docs: fix multiple broken links (eslint#14833) Chore: use `actions/setup-node@v2` (eslint#14816) Docs: Update README team and sponsors 7.31.0 Build: changelog update for 7.31.0 Upgrade: @eslint/eslintrc to v0.4.3 (eslint#14808) Update: add end location to report in `consistent-return` (refs eslint#12334) (eslint#14798) Docs: update BUG_REPORT template (eslint#14787) Docs: provide more context to no-eq-null (eslint#14801)
aladdin-add
added a commit
to eslint/eslintrc
that referenced
this pull request
Aug 5, 2021
it's as the same as we have done in the eslint repo: eslint/eslint#14816
aladdin-add
added a commit
to eslint/js
that referenced
this pull request
Aug 5, 2021
it's as the same as we have done in the eslint repo: eslint/eslint#14816
aladdin-add
added a commit
to eslint/eslintrc
that referenced
this pull request
Aug 5, 2021
it's as the same as we have done in the eslint repo: eslint/eslint#14816
brettz9
pushed a commit
to eslint/eslintrc
that referenced
this pull request
Aug 5, 2021
As applied to the eslint repo: eslint/eslint#14816
aladdin-add
added a commit
to eslint/js
that referenced
this pull request
Aug 5, 2021
* Chore: use actions/setup-node@v2 it's as the same as we have done in the eslint repo: eslint/eslint#14816 * Update ci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Other, please explain: CI related
What changes did you make? (Give an overview)
updated
setup-nodeaction tov2for CI node workflow.https://github.com/marketplace/actions/setup-node-js-environment
Is there anything you'd like reviewers to focus on?
No