Update: change reporting location for curly rule (refs #12334)#14766
Merged
Update: change reporting location for curly rule (refs #12334)#14766
curly rule (refs #12334)#14766Conversation
curly rulecurly rule (refs #12334)
2 tasks
Member
|
Now I think that highlighting the body/consequent/alternate node would make the most sense, as that's the part of the code that should be fixed. The rule reports "Expected '{' after 'while' condition.", but the whole body should be wrapped in a block. A similar rule |
Contributor
Author
|
Makes sense, I will update 👍 |
Contributor
Author
|
@mdjermanovic updated 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Refers #12334
Fixes #13282
Is there anything you'd like reviewers to focus on?
No