Update: Improving no-mixed-operators to clarify what changes need to be made.#14765
Merged
nzakas merged 1 commit intoeslint:masterfrom Jul 9, 2021
Merged
Update: Improving no-mixed-operators to clarify what changes need to be made.#14765nzakas merged 1 commit intoeslint:masterfrom
nzakas merged 1 commit intoeslint:masterfrom
Conversation
snitin315
approved these changes
Jul 4, 2021
Contributor
snitin315
left a comment
There was a problem hiding this comment.
I'm okay with change, it makes sense to me to provide a more helpful message. Let's wait for other team members to review this change.
mdjermanovic
approved these changes
Jul 4, 2021
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
Makes sense to me, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What rule do you want to change?
no-mixed-operators
Does this change cause the rule to produce more or fewer warnings?
no
How will the change be implemented? (New option, new default behavior, etc.)?
new default behavior
Please provide some example code that this change will affect:
What does the rule currently do for this code?
Current error message: "Unexpected mix of '*' and '/'."
What will the rule do after it's changed?
New error message: "Unexpected mix of '*' and '/'. Use parentheses to clarify the intended order of operations."
What changes did you make? (Give an overview)
Updated the error message for no-mixed-operators to clarify what changes need to made.
Is there anything you'd like reviewers to focus on?
Is there anything else that would make this error message clearer?