Update: support multiline /*eslint-env*/ directives (fixes #14652)#14660
Merged
mdjermanovic merged 3 commits intoeslint:masterfrom Jun 4, 2021
Merged
Update: support multiline /*eslint-env*/ directives (fixes #14652)#14660mdjermanovic merged 3 commits intoeslint:masterfrom
mdjermanovic merged 3 commits intoeslint:masterfrom
Conversation
mdjermanovic
reviewed
Jun 3, 2021
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
I think this should be tagged as Update:, as it could enable new globals in an existing code.
For example, this will be a new error:
/* eslint-env browser
*/
/* eslint no-shadow: ["error", { "builtinGlobals": true }] */
window => {}Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
update the regexp to allow linebreaks.
Is there anything you'd like reviewers to focus on?
not really.