Skip to content

Chore: remove loose-parser tests (fixes #14315)#14569

Merged
btmills merged 1 commit intomasterfrom
issue14315
May 8, 2021
Merged

Chore: remove loose-parser tests (fixes #14315)#14569
btmills merged 1 commit intomasterfrom
issue14315

Conversation

@mdjermanovic
Copy link
Copy Markdown
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

fixes #14315

What changes did you make? (Give an overview)

Removed tests/tools/loose-parser.js parser, no-redeclare tests that were using the parser, and acorn as a dev dependency.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels May 5, 2021
Copy link
Copy Markdown
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@btmills btmills merged commit 6a86e50 into master May 8, 2021
@btmills btmills deleted the issue14315 branch May 8, 2021 00:37
@eslint-github-bot eslint-github-bot Bot locked and limited conversation to collaborators Nov 5, 2021
@eslint-github-bot eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no-redeclare loose parser tests

4 participants