Docs: Improve documentation for indent rule#14168
Merged
mdjermanovic merged 5 commits intoeslint:masterfrom Mar 11, 2021
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Currently, all the options in indent rule except
SwitchCase,FunctionDeclaration.bodyandFunctionExpression.bodycan be set to "off" to disable checking.I was setting up linting for one of my projects and I wanted to enable indent rule for just
CallExpressionoption. After adding indent rule to eslint configuration file, default values for all options in indent rule are enabled. So, they are needed to be disabled explicitly.I disabled all the options except the ones above as they don't have "off" option. I could not understand how I can disable them. I think the description in
ignoredNodesoption is hard to see and understand because it is close to last option and it does not clearly say it can be used to disable any of options.My changes:
Is there anything you'd like reviewers to focus on?
No