Update: eslint --env-info output os info#14059
Merged
mdjermanovic merged 3 commits intoeslint:masterfrom Mar 20, 2021
Merged
Conversation
Member
|
I’m not sure it’s worth adding another dependency just to output debug information. Couldn’t we just use process.platform? |
Member
Author
|
the package can output more readable info, e.g. osName('win32', '6.3.9600');
//=> 'Windows 8.1'I think either is fine. will remove the dependency if you prefer that way. :) |
Member
|
As I said, I just don’t think this is important enough to add another dependency. Win32 or Win64 is plenty of info for our purposes. |
023f50b to
8c513d9
Compare
Member
Author
|
just rebased the latest master. |
Member
|
I think we can already mark this as accepted, since it matches our new bug report template. |
mdjermanovic
requested changes
Mar 11, 2021
Comment on lines
+61
to
+62
| os.platform = () => "darwin"; | ||
| os.release = () => "20.3.0"; |
Member
There was a problem hiding this comment.
Can we use sinon here to prevent this change from leaking to other tests?
nzakas
approved these changes
Mar 17, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ x] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
eslint --env-infoprint the os info, it looks like:Is there anything you'd like reviewers to focus on?
no.