Fix: Support ENOTDIR error code in the folder existence checking utility#13973
Merged
mdjermanovic merged 2 commits intoeslint:masterfrom Feb 10, 2021
Merged
Fix: Support ENOTDIR error code in the folder existence checking utility#13973mdjermanovic merged 2 commits intoeslint:masterfrom
mdjermanovic merged 2 commits intoeslint:masterfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Add a condition to return
falseindirectoryExistsfunction if Node API returnsENOTDIRerrorIs there anything you'd like reviewers to focus on?
Reproduced when special custom parsers were used:
jsonc-eslint-parsertogether witheslint-plugin-markdown. Happened during linting of JSON code fragments in Markdown document when checking virtual file paths, e.g.directoryExists('C:\Projects\Projects_Compane\project_name\README.md\2_2.json')More details can be found in this issue ota-meshi/eslint-plugin-jsonc#28