Chore: update eslint-config-eslint's required node version#13379
Merged
Chore: update eslint-config-eslint's required node version#13379
Conversation
it is a breaking change in eslint-config-eslint; tagged `Chore` to avoid eslint's major release.
1 task
kaicataldo
approved these changes
Jun 1, 2020
Member
Can you clarify what you mean by this? |
Member
Author
|
to |
Member
|
I think we also need to manually update the |
Member
|
I had to figure out how this worked, too. It looks like we have it set up to select the semver release type when kicking off the release (you can see the bot updating the version here), so this should be fine as-is! |
Member
|
Okay cool, then I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is a breaking change in eslint-config-eslint; tagged
Choreto avoid eslint's major release.Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Other, please explain:
What changes did you make? (Give an overview)
as the title.
Is there anything you'd like reviewers to focus on?
atm, the commit format(and release tool) did not consider
eslint-config-eslint-- there is a room to improve. :)