Skip to content

Update: enable es2020 environment in --init#13357

Merged
kaicataldo merged 1 commit intomasterfrom
configinit-es2020env
Jun 4, 2020
Merged

Update: enable es2020 environment in --init#13357
kaicataldo merged 1 commit intomasterfrom
configinit-es2020env

Conversation

@mdjermanovic
Copy link
Copy Markdown
Member

@mdjermanovic mdjermanovic commented May 25, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

Updates --init behavior.

What changes did you make? (Give an overview)

--init will now enable the latest es2020 env, instead of es6 env + es2017 globals.

Is there anything you'd like reviewers to focus on?

Does it make sense to enable the latest es environment in new projects? --init is already setting the latest ecmaVersion.

@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint cli Relates to ESLint's command-line interface evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 25, 2020
@yeonjuan
Copy link
Copy Markdown
Member

yeonjuan commented May 31, 2020

Does it make sense to enable the latest es environment in new projects? --init is already setting the latest ecmaVersion.

Agree. it makes sense to me! 👍

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 31, 2020
@kaicataldo
Copy link
Copy Markdown
Member

kaicataldo commented May 31, 2020

I think we should always just be using the latest (marking as accepted since I believe this is already the intention - please let me know if I'm wrong!).

@mdjermanovic
Copy link
Copy Markdown
Member Author

mdjermanovic commented Jun 1, 2020

Sorry for the confusing PR description!

Yes, the intention is to always enable the latest es* environment, which is es2020 at the moment.

Maybe we could figure out a way to do it without hard-coding, but that might be unnecessary work now given the proposed config changes in eslint/rfcs#9.

yeonjuan
yeonjuan approved these changes Jun 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@kaicataldo kaicataldo merged commit d5fce9f into master Jun 4, 2020
@kaicataldo kaicataldo deleted the configinit-es2020env branch June 4, 2020 20:25
@kaicataldo
Copy link
Copy Markdown
Member

kaicataldo commented Jun 4, 2020

Thanks for contributing!

@eslint-deprecated eslint-deprecated Bot locked and limited conversation to collaborators Dec 2, 2020
@eslint-deprecated eslint-deprecated Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@kaicataldo kaicataldo kaicataldo approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdjermanovic @yeonjuan @kaicataldo