Skip to content

Update: padded-blocks loc position changes (refs #12334)#13328

Merged
kaicataldo merged 1 commit intoeslint:masterfrom
anikethsaha:fixes-12334-padded-blocks
May 23, 2020
Merged

Update: padded-blocks loc position changes (refs #12334)#13328
kaicataldo merged 1 commit intoeslint:masterfrom
anikethsaha:fixes-12334-padded-blocks

Conversation

@anikethsaha
Copy link
Copy Markdown
Member

@anikethsaha anikethsaha commented May 19, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

BEFORE

  • always

image

  • never

image

AFTER

  • always

image

  • never

image

Is there anything you'd like reviewers to focus on?

refs #12334

@eslint-deprecated eslint-deprecated Bot added the triage An ESLint team member will look at this issue soon label May 19, 2020
@anikethsaha anikethsaha force-pushed the fixes-12334-padded-blocks branch from 5f7fce2 to 485baa0 Compare May 19, 2020 16:18
@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels May 20, 2020
@chiawendt chiawendt mentioned this pull request May 21, 2020
Closed
@kaicataldo kaicataldo merged commit df01af1 into eslint:master May 23, 2020
@kaicataldo
Copy link
Copy Markdown
Member

kaicataldo commented May 23, 2020

Thanks for contributing!

@eslint-deprecated eslint-deprecated Bot locked and limited conversation to collaborators Nov 20, 2020
@eslint-deprecated eslint-deprecated Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kaicataldo kaicataldo kaicataldo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anikethsaha @kaicataldo