Update: Improve report location for rest-spread-spacing (refs #12334)#13313
Merged
kaicataldo merged 1 commit intomasterfrom May 20, 2020
Merged
Update: Improve report location for rest-spread-spacing (refs #12334)#13313kaicataldo merged 1 commit intomasterfrom
kaicataldo merged 1 commit intomasterfrom
Conversation
kaicataldo
approved these changes
May 20, 2020
Member
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Other, please explain:
refs #12334
Change reported location in the
rest-spread-spacingrule.What changes did you make? (Give an overview)
For
"always", the rule will now report the full location of the rest/spread operator, instead of only its end location.For
"never", the rule will now report range between the rest/spread operator and the following token, instead of only the end location of the rest/spread operator."always"before this change:"always"after this change:"never"before this change:"never"after this change:Is there anything you'd like reviewers to focus on?