Docs: Document the "correct" way to build an array with values#13246
Merged
kaicataldo merged 2 commits intoeslint:masterfrom May 20, 2020
Merged
Docs: Document the "correct" way to build an array with values#13246kaicataldo merged 2 commits intoeslint:masterfrom
kaicataldo merged 2 commits intoeslint:masterfrom
Conversation
kaicataldo
suggested changes
May 1, 2020
Member
kaicataldo
left a comment
There was a problem hiding this comment.
Thanks for doing this! One small thing, but otherwise this LGTM.
anikethsaha
suggested changes
May 5, 2020
Member
anikethsaha
left a comment
There was a problem hiding this comment.
commit message has some formatting issue. You can refer the commit message convention
kaicataldo
approved these changes
May 19, 2020
Member
kaicataldo
left a comment
There was a problem hiding this comment.
This LGTM, though it looks like I'm unable to rerun the failed CI run in macOS. Is anyone else able to do so?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added an example to counter on the "incorrect" styles.
Is there anything you'd like reviewers to focus on?