Skip to content

Update: added typescript-eslint/recommended configs for init#13235

Merged
kaicataldo merged 1 commit intoeslint:masterfrom
anikethsaha:ts-config-init
May 14, 2020
Merged

Update: added typescript-eslint/recommended configs for init#13235
kaicataldo merged 1 commit intoeslint:masterfrom
anikethsaha:ts-config-init

Conversation

@anikethsaha
Copy link
Copy Markdown
Member

@anikethsaha anikethsaha commented Apr 29, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: init flag refactor

What changes did you make? (Give an overview)

added "plugin:@typescript-eslint/recommended" to extend configs when typescript prompt is true.

Is there anything you'd like reviewers to focus on?

fixes #13233
ref https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin#recommended-configs

As noted in the root README, not all ESLint core rules are compatible with TypeScript, so you need to add both eslint:recommended and plugin:@typescript-eslint/eslint-recommended
-from typescript-eslint docs

@eslint-deprecated eslint-deprecated Bot added the triage An ESLint team member will look at this issue soon label Apr 29, 2020
aladdin-add
aladdin-add approved these changes May 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add requested a review from kaicataldo May 5, 2020 17:56
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint and removed triage An ESLint team member will look at this issue soon labels May 5, 2020
kaicataldo
kaicataldo reviewed May 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@kaicataldo kaicataldo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM (and I support this change), but I'm not sure why this has been marked as accepted. I think we'll want to go through our standard proposal acceptance process for this. @aladdin-add Mind filling us in on why this has been marked as accepted?

@anikethsaha
Copy link
Copy Markdown
Member Author

anikethsaha commented May 5, 2020

This LGTM (and I support this change), but I'm not sure why this has been marked as accepted. I think we'll want to go through our standard proposal acceptance process for this. @aladdin-add Mind filling us in on why this has been marked as accepted?

@kaicataldo I am sorry as I submitted PR without the accepted label. I did as this was a small change and it was mentioned in the typescript-eslint repo so I thought of moving it fast with PR and discussing in the PR.

@aladdin-add aladdin-add added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed accepted There is consensus among the team that this change meets the criteria for inclusion labels May 5, 2020
@aladdin-add
Copy link
Copy Markdown
Member

aladdin-add commented May 5, 2020

removed accepted, added evaluating.

sorry for confusion! 😄

@kaicataldo
Copy link
Copy Markdown
Member

kaicataldo commented May 5, 2020

@anikethsaha No need to apologize - there's nothing wrong with submitting a PR before it's accepted! In fact, it makes it easier for us to evaluate the proposal :). I just want to make sure we go through our standard process so that the whole team has the chance to evaluate the proposal.

@aladdin-add No problem!

@kaicataldo kaicataldo self-assigned this May 5, 2020
@kaicataldo
Copy link
Copy Markdown
Member

kaicataldo commented May 5, 2020

I'll champion this. We just need 3 👍s from the team to accept this.

@kaicataldo kaicataldo mentioned this pull request May 5, 2020
Closed
@yeonjuan
Copy link
Copy Markdown
Member

yeonjuan commented May 7, 2020

It make sense to me. 👍

@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 7, 2020
@mdjermanovic mdjermanovic mentioned this pull request May 8, 2020
Closed
mdjermanovic
mdjermanovic approved these changes May 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo kaicataldo merged commit 742941d into eslint:master May 14, 2020
@kaicataldo
Copy link
Copy Markdown
Member

kaicataldo commented May 14, 2020

Thanks for contributing!

@anikethsaha anikethsaha deleted the ts-config-init branch May 14, 2020 19:46
@eslint-deprecated eslint-deprecated Bot locked and limited conversation to collaborators Nov 11, 2020
@eslint-deprecated eslint-deprecated Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

+2 more reviewers

@btmills btmills btmills approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaicataldo kaicataldo

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auto-fix typescript's no-unused-var rule using --init

6 participants

@anikethsaha @aladdin-add @kaicataldo @yeonjuan @btmills @mdjermanovic