Update: add missing additionalProperties: false to some rules' schema#13198
Merged
Update: add missing additionalProperties: false to some rules' schema#13198
additionalProperties: false to some rules' schema#13198Conversation
2 tasks
kaicataldo
approved these changes
Jun 13, 2020
Member
|
I'd like another review before merging, but this makes sense to me and I agree that this should be a semver-minor bug fix. |
btmills
approved these changes
Jun 19, 2020
Member
btmills
left a comment
There was a problem hiding this comment.
I agree that this is a semver-minor bugfix. The rest of the rules' schemas establish the precedent that we'll use additionalProperties: false to prevent accidental misconfigurations, and it's unexpected that these three rules didn't have that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
Online Demo
What did you expect to happen?
ESLint to report invalid configuration for all 3 rules, because
"foo"isn't an expected property.This is how almost all rules work, to avoid typos and misconfiguration.
What actually happened? Please include the actual, raw output from ESLint.
no warnings
What changes did you make? (Give an overview)
Added
additionalProperties: falseto the following rules:id-matchno-unused-varspadded-blocksIs there anything you'd like reviewers to focus on?
I think this kind of fixes should be semver-minor.