Update: add enforceForFunctionPrototypeMethods option to no-extra-parens#12895
Merged
kaicataldo merged 1 commit intomasterfrom Jun 5, 2020
Merged
Update: add enforceForFunctionPrototypeMethods option to no-extra-parens#12895kaicataldo merged 1 commit intomasterfrom
kaicataldo merged 1 commit intomasterfrom
Conversation
kaicataldo
approved these changes
Jun 5, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Bug fix
[X] Changes an existing rule
Fixes #12870
This PR adds
enforceForFunctionPrototypeMethodsoption to theno-extra-parensrule in order to avoid conflicts withwrap-iife"functionPrototypeMethods": true.Examples of correct code:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
Yes! Should we add this option to
"functions"schema, too? It doesn't have any options at the moment. That used to be a separate rule, but got merged inno-extra-parensat some point?This is also a conflict: